Add first person observer view#57
Merged
Manishearth merged 5 commits intoimmersive-web:masterfrom Jun 18, 2020
Merged
Conversation
cabanier
reviewed
Jun 11, 2020
index.bs
Outdated
|
|
||
| [=First-person observer views=] MAY use a different [=blend technique=] over the primary [=views=]. In such a case, this [=blend technique=] MAY be exposed on the {{XRView}} through {{XRView/overrideBlendMode}}. | ||
|
|
||
| The <dfn attribute for=XRView>overrideBlendMode</dfn> attribute is <code>null</code> for all primary [=views=], and is the [=view=]'s [=blend technique=] for [=views=] where the [=blend technique=] differs from the {{XRSession/environmentBlendMode}}. |
Member
There was a problem hiding this comment.
When will an observer view ever be not alpha-blend'?
Contributor
Author
There was a problem hiding this comment.
Hm that's a good point.
I actually wrote this text back when I was thinking of having a general "secondary-views" feature (as discussed in the other spec) and in that case you definitely want this. But if we're doing FPO only it seems reasonable to mandate that the blend mode is always alpha-blend.
cabanier
reviewed
Jun 11, 2020
index.bs
Outdated
|
|
||
| Many AR devices have a camera, however the camera is typically not aligned with the eyes. When doing video capture of the session for streaming or saving to a file, it is suboptimal to simply composite this camera feed with one of the rendered eye feeds as there will be an internal offset. Devices may use reprojection or other tricks to fix up the stream, but some may expose a third [=view=], the <dfn>first-person observer view</dfn>, which has an [=view/eye=] of {{XREye/"none"}}. | ||
|
|
||
| Most content will not expect more than two [=view=]s, and content MUST explicitly opt-in to receiving a [=first-person observer view=] by enabling a "<dfn>first-person-observer</dfn>" [=feature descriptor=]. |
Member
There was a problem hiding this comment.
Most content will not expect more than two [=view=]s, and
remove this sentence
cabanier
reviewed
Jun 11, 2020
index.bs
Outdated
| First Person Observer Views {#first-person-observer} | ||
| -------------------------------- | ||
|
|
||
| Many AR devices have a camera, however the camera is typically not aligned with the eyes. When doing video capture of the session for streaming or saving to a file, it is suboptimal to simply composite this camera feed with one of the rendered eye feeds as there will be an internal offset. Devices may use reprojection or other tricks to fix up the stream, but some may expose a third [=view=], the <dfn>first-person observer view</dfn>, which has an [=view/eye=] of {{XREye/"none"}}. |
Contributor
Author
There was a problem hiding this comment.
It can't be, we're defining the view type.
Member
There was a problem hiding this comment.
Maybe you can break it apart in 2 sections.
Contributor
Author
|
This has been tweaked to have the feature descriptor be more generic and in the core spec (immersive-web/webxr#1083) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a first-person-observer feature flag that can be used to signal support for a first person observer view.
cc @cabanier @thetuvix
Fixes #53