Stop returning original file when the optimization is larger than the original file#285
Merged
sindresorhus merged 3 commits intoimagemin:masterfrom Dec 25, 2018
malash:remove-length-optimization
Merged
Stop returning original file when the optimization is larger than the original file#285sindresorhus merged 3 commits intoimagemin:masterfrom malash:remove-length-optimization
sindresorhus merged 3 commits intoimagemin:masterfrom
malash:remove-length-optimization
Conversation
This was referenced Nov 28, 2018
length|
Maybe we should add an option |
|
But then this needs to be done for all plugins that support such option whereas here it was in one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some plugins, like
imagemin-svgo'saddAttributesToSVGElementplugin, may increase image size.So here
imagemin/index.js
Line 24 in 37178f2
and
imagemin/index.js
Line 73 in 37178f2
may cause plugins to fail.
I advice to disable the optimization based on
length.I think it should be users' duty and right to detect which plugin is effective and which one should be abandoned but
imageminshouldn't do that work.