Filter out junk files#284
Merged
sindresorhus merged 3 commits intoimagemin:masterfrom Jun 30, 2019
tprobinson:add-junk-filter
Merged
Filter out junk files#284sindresorhus merged 3 commits intoimagemin:masterfrom tprobinson:add-junk-filter
sindresorhus merged 3 commits intoimagemin:masterfrom
tprobinson:add-junk-filter
Conversation
index.js
Outdated
|
|
||
| return globby(input, {nodir: true}).then(paths => Promise.all(paths.map(x => handleFile(x, output, opts)))); | ||
| return globby(input, {nodir: true}) | ||
| .then(paths => Promise.resolve(paths.filter(path => junk.not(path)))) |
Contributor
There was a problem hiding this comment.
The Promise.resolve call is moot and you can just put the filter logic in the same .then as the Promise.all call.
Contributor
Author
|
Sorry it took me so long to get back to this! It's all synced up with master, and I rewrote the test to actually do something useful. |
index.js
Outdated
|
|
||
| return globby(input, {onlyFiles: true}).then(paths => Promise.all(paths.map(x => handleFile(x, output, options)))); | ||
| return globby(input, {onlyFiles: true}) | ||
| .then(paths => Promise.all(paths.reduce((acc, x) => junk.is(path.basename(x)) ? acc : acc.concat(handleFile(x, output, options)), []))); |
Contributor
There was a problem hiding this comment.
Using reduce here just makes the code much less readable. Would be better to use filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247. A test is included, not sure if I did it right.