More mass density and specific volume units#489
Merged
iliekturtles merged 2 commits intoFeb 16, 2025
Merged
Conversation
aa5502d to
f28c0e3
Compare
Owner
|
Thank you for the PR and sorry for the delay. I amended your commits with a few formatting changes and have merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two new mass density units:
ton_long_per_cubic_footandton_short_per_cubic_foot. Additionally, it includes the inverse units for all mass density units inSpecificVolume.Key Changes
ton_long_per_cubic_footandton_short_per_cubic_footMassDensityunits have been added toSpecificVolumeSpecificVolumetests now useTest::assert_approx_eqIt would be great to get these units added, and I’m happy to address any feedback or comments.