Add AngularMomentum#463
Closed
ISibboI wants to merge 1 commit into
Closed
Conversation
iliekturtles
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR! and sorry for my delay in responding. I've done a very brief review and things look really good. So far I only have a couple comments:
- Are there other common units of angular momentum that can be added? Vary the mass and/or time portions?
- Will you setup a
check_dimensiontest and acheck_unitstest for each individual unit. Seeaccelerationfor an example.
Contributor
Author
|
Thanks! I am sorry, but I don't have time to add functionality beyond what I need. |
Owner
|
Thanks so much for the initial efforts. Closing this PR as #479 now supersedes this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #460.