Add quantity inverse velocity#420
Merged
Merged
Conversation
8756d59 to
34f42ec
Compare
Owner
|
Thanks for the PR. Merged! |
Contributor
Author
|
@iliekturtles Certainly, thank you for merging! Out of curiosity, how soon do you expect to have these quantities released on crates.io? |
Owner
|
I don't have any specific time frame, but I can look to get it done soon for you. |
Owner
Contributor
Author
|
@iliekturtles Thank you for letting me know! I'll be switching back to the main repo as soon as it is released |
Owner
|
v0.35.0 published! |
| "minutes per foot"; | ||
| @second_per_foot: 3.280_839_895_013_123; "s/ft", "second per foot", "seconds per foot"; | ||
| @second_per_inch: 3.937_007_874_015_748_E1; "s/in", "second per inch", "seconds per inch"; | ||
| @hour_per_kilometer: 3.6; "h/km", "hour per kilometer", "hours per kilometer"; |
Contributor
There was a problem hiding this comment.
Was there a reason you added @minute_per_mile but not @minute_per_kilometer? Would there be any objection to adding it and closing #416?
Contributor
Author
There was a problem hiding this comment.
Only reason was that it wasn't in the base velocity units at the time I put together inverse_velocity. I have no objections to adding it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe I've changed everything necessary to add inverse velocity (base units are seconds per meter). Please let me know if I missed anything required to merge! I've split this off from the power rate PR to make the changes clearer. I can also recombine them if you'd prefer!