Add quantity: CarbonIntensity (Mass/Energy)#410
Conversation
Carbon intensity
Carbon intensityCarbon intensity
Carbon intensityCarbonIntensity
CarbonIntensityCarbonIntensity (Mass/Energy)
|
Thanks for the PR!
|
|
Thx for the quick response. |
|
I did find a reference to Regardless of what the quantity ends up being named, emission intensity and carbon intensity should be prominently mentioned in the documentation as this appears to be the primary use for the quantity. |
|
Changes look good. I pushed a bunch of formatting fixes to your fork. Could you please review, go ahead with the change to |
|
I changed the name to |
iliekturtles
left a comment
There was a problem hiding this comment.
Couple more comments with this review. Could you also update the commit message:
Add mass per energy quantity.
Generalization of emission intensity (carbon intensity) as mass per energy.
| areal_number_rate::ArealNumberRate, | ||
| available_energy::AvailableEnergy, | ||
| capacitance::Capacitance, | ||
| mass_per_energy::MassPerEnergy, |
There was a problem hiding this comment.
Re-sort mod.rs:
| mass_per_energy::MassPerEnergy, |
diff --git a/src/si/mod.rs b/src/si/mod.rs
index 5584c84..4d68ba3 100644
--- a/src/si/mod.rs
+++ b/src/si/mod.rs
@@ -61,7 +61,6 @@ system! {
areal_number_rate::ArealNumberRate,
available_energy::AvailableEnergy,
capacitance::Capacitance,
- mass_per_energy::MassPerEnergy,
catalytic_activity::CatalyticActivity,
catalytic_activity_concentration::CatalyticActivityConcentration,
curvature::Curvature,
@@ -113,6 +112,7 @@ system! {
mass_concentration::MassConcentration,
mass_density::MassDensity,
mass_flux::MassFlux,
+ mass_per_energy::MassPerEnergy,
mass_rate::MassRate,
molality::Molality,
molar_concentration::MolarConcentration,There was a problem hiding this comment.
The reordering was done in the latest squashed commit.
| @@ -0,0 +1,121 @@ | |||
| //! Mass per energy (base unit kilogram per joule, m⁻² · s²). | |||
There was a problem hiding this comment.
Add something about mass per energy most commonly being used as emission intensity/carbon intensity.
There was a problem hiding this comment.
I added a description of the typical use case of the generalization and a short explanation what is expressed by that use case.
|
I implemented the requested changes. |
Generalization of emission intensity (carbon intensity) as mass per energy.
|
I pushed some formatting for the module comment and merged. Thanks so much for the PR! |
During the development of code related to carbon intensity we did not find any quantity that can express mass per energy.
In this PR we propose a quantity we named CarbonIntensity.
A sample unit for this quantity would be g/kWh, which we use to express gCO2/kWh.
Maybe the name CarbonIntensity is already too specific and could be changed to something more general.
I would be happy to discuss about that.