Skip to content

Add quantity: AngularAbsement#409

Merged
iliekturtles merged 1 commit into
iliekturtles:masterfrom
professoralex13:master
Mar 8, 2023
Merged

Add quantity: AngularAbsement#409
iliekturtles merged 1 commit into
iliekturtles:masterfrom
professoralex13:master

Conversation

@professoralex13

Copy link
Copy Markdown
Contributor

Adds an AngleKind version of Absement

@iliekturtles

Copy link
Copy Markdown
Owner

Thanks for the PR! I've started the tests and a quick scan of the code looks good. Will try to do a more thorough review later today.

@iliekturtles

Copy link
Copy Markdown
Owner

I pushed some formatting and typo fixes to your fork. Could you review, squash, and set an updated commit message. Something like the one on my commit.

@professoralex13

Copy link
Copy Markdown
Contributor Author

I pushed some formatting and typo fixes to your fork. Could you review, squash, and set an updated commit message. Something like the one on my commit.

sounds good, have done that

@iliekturtles iliekturtles merged commit fa4257c into iliekturtles:master Mar 8, 2023
@iliekturtles

Copy link
Copy Markdown
Owner

Merged! Thanks again for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants