Thermal conductance#408
Merged
Merged
Conversation
Owner
|
Thanks for the PR! Changes look really good. I pushed some minor fixes to your branch Mostly formatting. Please review and squash everything down to one commit. Test suite is running now. |
98a9768 to
8420e1d
Compare
Author
@iliekturtles, I think we're all set! BTW, your user name is great. My wife and I have saved numerous snapping turtles that were crossing roads by helping them across and blocking traffic. |
Owner
|
Could you also update the commit message on the squashed commit. Something like EDIT: I like turtles! |
* units of W / K * heat transfer rate per temperature difference Commit history: copied from thermal_conductivity.rs thermal_conductance seems to work. tests pass Code review fixes * Fix Celsius casing. * Formatting.
8420e1d to
0f73157
Compare
Author
|
@iliekturtles , should be all set now! |
Owner
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty sure I got this right. I need thermal conductance [W/K] for a number of projects I'm working on so I thought I'd try a PR. Let me know if anything important needs attention. Please check my work!