Added new units for Pressure and VolumeRate#397
Closed
Eagle941 wants to merge 22 commits into
Closed
Conversation
| @decaliter_per_second: prefix!(milli) * prefix!(deca); "daL/s", "decaliter per second", | ||
| "decaliters per second"; | ||
| @liter_per_second: prefix!(milli); "L/s", "liter per second", "liters per second"; | ||
| @liter_per_minute: prefix!(milli) / 60.; "L/min", "liter per minute", "liters per minute"; |
Owner
There was a problem hiding this comment.
Move this line down to a new group underneath @yoctoliter_per_second. Add a test case as well.
Owner
There was a problem hiding this comment.
EDIT: change the conversion factor to prefix!(milli) / 6.0_E1;.
iliekturtles
left a comment
Owner
There was a problem hiding this comment.
Looks like something went wrong during your rebase. If you make sure your upstream remote for iliekturtles/uom is up to date you can rebase -i iliekturtles/master, squash all the commits together, apply the minor formatting changes below, and update the commit message.
| "zeptoliters per second"; | ||
| @yoctoliter_per_second: prefix!(milli) * prefix!(yocto); "yL/s", "yoctoliter per second", | ||
| "yoctoliters per second"; | ||
| @liter_per_minute: prefix!(milli) / 6.0_E1; "L/min", "liter per minute", "liters per minute"; |
Owner
There was a problem hiding this comment.
Suggested change
| @liter_per_minute: prefix!(milli) / 6.0_E1; "L/min", "liter per minute", "liters per minute"; | |
| @liter_per_minute: prefix!(milli) / 6.0_E1; "L/min", "liter per minute", | |
| "liters per minute"; |
| test::<v::attoliter, t::second, r::attoliter_per_second>(); | ||
| test::<v::zeptoliter, t::second, r::zeptoliter_per_second>(); | ||
| test::<v::yoctoliter, t::second, r::yoctoliter_per_second>(); | ||
| test::<v::liter, t::minute, r::liter_per_minute>(); |
Owner
There was a problem hiding this comment.
Suggested change
| test::<v::liter, t::minute, r::liter_per_minute>(); | |
| test::<v::liter, t::minute, r::liter_per_minute>(); |
Added new units Add fixes to liter per minute Rebase and added unit test for liter_per_minute Added new units Add fixes to liter per minute Added new units Add fixes to liter per minute Fixed format Fixed format
… be resolved. Part of iliekturtles#392.
Added new units Add fixes to liter per minute Rebase and added unit test for liter_per_minute Added new units Add fixes to liter per minute Added new units Add fixes to liter per minute Fixed format Fixed format Added liter_per_minute and newton_per_square_millimeter Added new units for VolumeRate and Pressure Added new units Add fixes to liter per minute Fixed format Fixed format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following two units:
newton_per_square_millimeterliter_per_minute