Add defmt::Format implementation#386
Closed
therealfrauholle wants to merge 3 commits into
Closed
Conversation
added 3 commits
October 22, 2022 19:00
This allows for more efficiency on the wire. The inefficient implementation is still desired since this allows to use derive(defmt::Format) on structs containing uom quantities.
This makes cargo fmt happy
834206e to
6c80444
Compare
Closed
Author
|
Cannot continue due to MSRV, will reopen when possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #385
This is a draft, since I still need to run the code. To my knowledge there is no easy way to test
defmt::Formatimplementations.