Skip to content

Add action quantity with corresponding units and tests.#325

Merged
iliekturtles merged 1 commit into
iliekturtles:masterfrom
crystal-growth:add_action
Oct 26, 2022
Merged

Add action quantity with corresponding units and tests.#325
iliekturtles merged 1 commit into
iliekturtles:masterfrom
crystal-growth:add_action

Conversation

@crystal-growth

@crystal-growth crystal-growth commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

Adding quantity for Action [Energy x Time] with units:

  • joule second
  • erg second
  • eV second
  • reduced Planck constant as an atomic unit of action
  • "normal" Planck constant

@crystal-growth crystal-growth force-pushed the add_action branch 2 times, most recently from 358040e to ae22375 Compare August 12, 2022 07:42

@iliekturtles iliekturtles left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't end up finishing this review.

Comment thread src/si/action.rs Outdated
Comment thread src/si/action.rs Outdated
@iliekturtles iliekturtles merged commit f187efa into iliekturtles:master Oct 26, 2022
@iliekturtles

Copy link
Copy Markdown
Owner

Thanks for the PR and sorry for delays. I thought I was going to get to these a month ago!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants