Skip to content

Add dynamic viscosity quantity with related units and tests#323

Merged
iliekturtles merged 1 commit into
iliekturtles:masterfrom
crystal-growth:add_dynamic_viscosity
Aug 15, 2022
Merged

Add dynamic viscosity quantity with related units and tests#323
iliekturtles merged 1 commit into
iliekturtles:masterfrom
crystal-growth:add_dynamic_viscosity

Conversation

@crystal-growth

Copy link
Copy Markdown
Contributor

Dynamic viscosity quantity [Pressure x Time] with derived and imperial units.

@crystal-growth

Copy link
Copy Markdown
Contributor Author

Rebased to current master, fixing merge conflict in mod.rs.

Comment thread src/si/dynamic_viscosity.rs Outdated
Comment thread src/si/dynamic_viscosity.rs Outdated
Comment thread src/si/dynamic_viscosity.rs Outdated
Comment thread src/si/dynamic_viscosity.rs Outdated
Comment thread src/si/dynamic_viscosity.rs Outdated
Comment thread src/si/dynamic_viscosity.rs Outdated
Comment thread src/si/dynamic_viscosity.rs Outdated
@crystal-growth

Copy link
Copy Markdown
Contributor Author

I'm not sure about plurals for Poise
"Poises" is frequently used, especially in older literature:
https://ceramics.onlinelibrary.wiley.com/doi/abs/10.1111/j.1151-2916.1963.tb11684.x
https://www.sciencedirect.com/science/article/pii/001910359190090G
Same for reyn:
"Reyns" are used in older texts: https://ntrs.nasa.gov/api/citations/19930083501/downloads/19930083501.pdf

The newer texts use standard SI units or abbreviations

@iliekturtles iliekturtles left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor formatting then I think we're ready to merge!

Comment thread src/si/dynamic_viscosity.rs Outdated
Comment thread src/si/dynamic_viscosity.rs Outdated
Comment thread src/si/dynamic_viscosity.rs Outdated
Comment thread src/si/dynamic_viscosity.rs Outdated
Co-authored-by: Mike Boutin <mike.boutin@gmail.com>
@crystal-growth

Copy link
Copy Markdown
Contributor Author

Thank you!
Rebased and squashed into one commit.

@iliekturtles iliekturtles merged commit 10d9679 into iliekturtles:master Aug 15, 2022
@iliekturtles

Copy link
Copy Markdown
Owner

Thanks so much for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants