feat: add absement quantity and units#284
Conversation
|
Thanks for the PR! I'm going to try to review today. |
|
Changes look really good. Only change that is really needed is wrapping one of the long lines: diff --git a/src/si/absement.rs b/src/si/absement.rs
index a4b56a8..59bcaf1 100644
--- a/src/si/absement.rs
+++ b/src/si/absement.rs
@@ -74,7 +74,8 @@ mod tests {
#[test]
fn check_dimension() {
- let _: Absement<V> = Length::new::<l::meter>(V::one()) * Time::new::<t::second>(V::one());
+ let _: Absement<V> = Length::new::<l::meter>(V::one())
+ * Time::new::<t::second>(V::one());
}
#[test]Are there any other common units that should be added right now? You're also welcome to squash your commits into one. |
Sure thing, 549c53e should handle that.
I think the most common ones are likely to be
No problem, I'll squash and force push now. |
549c53e to
00c59f4
Compare
|
Excellent! Will merge once the build passes. |
|
Thanks for reviewing, and for |
Absement is a measure of the time-integrated displacement of an object. It is measured as a product of length and time. This PR adds an
absementmodule to the SI system along with corresponding units.