Skip to content

Explain how to manually enable Serde support for num-rational and num-bigint#272

Merged
iliekturtles merged 1 commit into
iliekturtles:masterfrom
adamreichold:explain-serde-opt-deps
Mar 17, 2022
Merged

Explain how to manually enable Serde support for num-rational and num-bigint#272
iliekturtles merged 1 commit into
iliekturtles:masterfrom
adamreichold:explain-serde-opt-deps

Conversation

@adamreichold

@adamreichold adamreichold commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

Fixes #269

Comment thread README.md Outdated
@iliekturtles

Copy link
Copy Markdown
Owner

If you could also wrap the changes in lib.rs (diff below) I'll accept!

diff --git a/src/lib.rs b/src/lib.rs
index 22d7816..be430b4 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -98,9 +98,9 @@
 //!  * `use_serde` -- Feature to enable support for serialization and deserialization of quantities
 //!    with the [Serde][serde] crate. Disabled by default.
 //!
-//!    [Serde][serde] support for the `big*` and `rational*` underlying storage types requires manually
-//!    enabling the `serde` feature for the `num-rational` and `num-bigint` crates. To do so, you can
-//!    add one or both of the following lines to your `Cargo.toml`:
+//!    [Serde][serde] support for the `big*` and `rational*` underlying storage types requires
+//!    manually enabling the `serde` feature for the `num-rational` and `num-bigint` crates. To do
+//!    so, you can add one or both of the following lines to your `Cargo.toml`:
 //!
 //!    ```toml
 //!    num-rational = { version = "*", features = ["serde"] }

@adamreichold

Copy link
Copy Markdown
Contributor Author

If you could also wrap the changes in lib.rs (diff below)

Applied.

@iliekturtles iliekturtles merged commit 66a0546 into iliekturtles:master Mar 17, 2022
@iliekturtles

Copy link
Copy Markdown
Owner

Thanks for the PR. Sorry it took so long to get resolved.

@adamreichold adamreichold deleted the explain-serde-opt-deps branch March 17, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot (de-)serialize rational64 with serde

2 participants