Update quickcheck#260
Merged
Merged
Conversation
7d9d06d to
7080595
Compare
82d9c2c to
2262014
Compare
2262014 to
c444a83
Compare
Change is required for future dependency updates.
The feature will be removed in a future release of uom. Functionality previously exposed by the feature is now enabled by default.
8429145 to
2726c37
Compare
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 96.78% 97.39% +0.61%
==========================================
Files 58 58
Lines 2735 2846 +111
==========================================
+ Hits 2647 2772 +125
+ Misses 88 74 -14
Continue to review full report at Codecov.
|
2726c37 to
254e2fd
Compare
Change required the MSRV update as well as refactoring `from_base`, `to_base`, and multiple tests. The `from_base` and `to_base` changes provide better floating point precision while still maintaing zero-cost guarantees. The test changes better handle floating point precision issues as well as the wider range of values generated by `quickcheck` 1.0's `Arbitrary` implementation.
254e2fd to
cad039c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the latest version. Requires fixing floating point precision issues since the latest version of quickcheck provides a better range of values that weren't seen before. Will also require bumping the MSRV.