Add constants to Angle representing half and full turns#191
Merged
iliekturtles merged 1 commit intoJun 16, 2020
Conversation
Various trigonometric computations require Angle constants of these values but as construction via Angle::new is not possible in constants, this uses fixed storage types and base units to directly construct Quantity literals to wrap the standard libraries constants for π.
Owner
|
Thanks for the PR! I meant to review today but got tied up. Will get done tomorrow morning. There was, possibly spurious, build failure so I restarted Travis. |
Owner
|
Looks like the build failure is something introduced in Beta 1.45/Nightly and is unrelated to this PR so I have merged! I'm still investigating the failure and will report it upstream. Thanks again for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various trigonometric computations require Angle constants of these values but as construction via Angle::new is not possible in constants, this uses fixed storage types and base units to directly construct Quantity literals to wrap the standard libraries constants for π.