Represented textual expression using CustomDebugStringConvertible.#193
Merged
ikesyo merged 1 commit intoikesyo:masterfrom May 11, 2018
Merged
Conversation
…rotocol instead of `CustomStringConvertible` protocol.
Owner
|
Sorry for the really late response 🙇 But this makes sense! Thanks for the pull request 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Represented textual expression using
CustomDebugStringConvertibleprotocol instead ofCustomStringConvertibleprotocol.Motivation
This motivation is that I'd like to customize a text representation of
DecodeErrorinstance to displaying error message in my application. I tried to makeDecodeErrorconform toCustomStringConvertibleprotocol, but it was already conformed to it, so I couldn't do that.Express as a debug information
In addition, I think the textual expression of
DecodeErrorthat are provided byCustomStringConvertibleseems to be debug information.In this reason, I'd like to propose to express the information using
CustomDebugStringConvertibleprotocol instead ofCustomStringConvertibleprotocol.For the same reason, I'd like to propose that to
ExtractorandKeyPathtoo.