Skip to content

Allowlist option (based on the shared registry implementation)#497

Merged
ikatson merged 8 commits into
ikatson:mainfrom
YGGverse:shared-list
Oct 14, 2025
Merged

Allowlist option (based on the shared registry implementation)#497
ikatson merged 8 commits into
ikatson:mainfrom
YGGverse:shared-list

Conversation

@oooo-ps

@oooo-ps oooo-ps commented Oct 14, 2025

Copy link
Copy Markdown

Shared list implementation #495, #496

ikatson
ikatson requested changes Oct 14, 2025
View reviewed changes

@ikatson ikatson left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the same pull request, no need to create new ones. Just force push (git push -f) to overwrite the previous version

Comment thread crates/librqbit/src/lib.rs Outdated
@oooo-ps

oooo-ps commented Oct 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

also, applied clippy, last one: do you want it or I can remove by the way?

cargo clippy
warning: struct `GetPeersResponse` is never constructed
   --> crates/dht/src/bprotocol.rs:367:12
    |
367 | pub struct GetPeersResponse<BufT: ByteBufT> {
    |            ^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: `librqbit-dht` (lib) generated 1 warning

@oooo-ps oooo-ps requested a review from ikatson October 14, 2025 15:55
@ikatson ikatson merged commit afcc0ec into ikatson:main Oct 14, 2025
4 checks passed
This was referenced Oct 14, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikatson ikatson Awaiting requested review from ikatson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oooo-ps @ikatson