Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for embedded BEDPE-style interaction features and a colorBy option with customizable color tables in the InteractionTrack (and aligns similar behavior in FeatureTrack).
- Introduce
ColorTable/PaletteColorTableimports and default palette logic - Add
colorByconfig,getColorhelper, andfixFeaturesfor embedded feature extents - Provide two new dev examples (
embedded.html,bedpe-color.html) to illustratecolorByand custom coloring
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| js/feature/interactionTrack.js | Add colorBy support, import color tables, implement getColor and fixFeatures helpers |
| js/feature/featureTrack.js | Align colorBy handling and object formatting in track UI menu |
| dev/interact/embedded.html | New example showing embedded interact features colored by type |
| dev/interact/bedpe-color.html | Example demonstrating custom color field on BEDPE records |
Comments suppressed due to low confidence (1)
js/feature/interactionTrack.js:313
- The new
getColorandfixFeatureslogic introduces important behavior forcolorByand embedded features but lacks unit tests. Consider adding tests covering these code paths.
getColor(feature) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tionTrack