Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a configurable "hideTags" property to customize which tags are hidden in the alignment popup view. Key changes include modifying the BamAlignment.popupData method to accept a hiddenTags parameter, updating AlignmentTrack to pass the new property, and modifying the demo configuration in bam.html.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| js/bam/bamAlignment.js | Updated popupData method to receive a hiddenTags parameter and adjusted tag list generation. |
| js/bam/alignmentTrack.js | Added hiddenTags property from config and passed it to popupData; minor update to tagColorPallete property. |
| dev/alignment/bam.html | Updated configuration to include a hideTags array for filtering tags. |
Comments suppressed due to low confidence (1)
js/bam/alignmentTrack.js:65
- Consider renaming 'tagColorPallete' to 'tagColorPalette' for clarity and consistency.
tagColorPallete: "Set1"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.