Bug fix: Overlay/Separate track order preserved#1970
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug with preserving the overlay and separate track order by introducing asynchronous handling for track reordering.
- Converted synchronous click handlers to async functions.
- Added await calls for browser view updates and track reordering in both overlayTrackButton.js and mergedTrack.js.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| js/ui/overlayTrackButton.js | Made trackOverlayClickHandler async and awaited reorderTracks |
| js/feature/mergedTrack.js | Made click handler async and awaited updateViews and reorderTracks |
js/ui/overlayTrackButton.js
Outdated
| this.browser.addTrack(mergedTrack) | ||
| mergedTrack.trackView.updateViews() | ||
|
|
||
| await this.browser.reorderTracks() |
There was a problem hiding this comment.
Consider adding error handling around the asynchronous call to 'reorderTracks' to manage any potential failures gracefully.
Suggested change
| await this.browser.reorderTracks() | |
| try { | |
| await this.browser.reorderTracks() | |
| } catch (error) { | |
| console.error("Failed to reorder tracks:", error); | |
| // Optionally, notify the user or take other recovery actions here | |
| } |
| element.textContent = 'Separate tracks'; | ||
|
|
||
| function click(e) { | ||
| async function click(e) { |
There was a problem hiding this comment.
Using a plain async function here may cause 'this' to lose its intended binding when 'click' is invoked. Consider using an arrow function (e.g., 'click = async (e) => {') to preserve the lexical 'this' context.
Suggested change
| async function click(e) { | |
| const click = async (e) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.