Adapt Python interface to new UMAP changes#613
Merged
ntamas merged 8 commits intoigraph:masterfrom Nov 24, 2022
Merged
Conversation
Member
Author
|
One question would be if you want this to be a function rather than a |
szhorvat
reviewed
Nov 22, 2022
Member
|
I'd prefer a separate function; this particular function is way too much tied to the UMAP layout algorithm so I don't think it belongs to the |
Member
|
Looks good to me! Please update the changelog and then I'll merge. |
Member
Author
|
Please go ahead good sir ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started adapting the Python interface to the new UMAP API changes:
GraphmethodReady for review. The docs are a little sketchy still so if someone could take a look and rephrase that'd help.