Matplotlib plotting and clustering color bugfix#410
Merged
ntamas merged 1 commit intoigraph:masterfrom Jun 2, 2021
Merged
Conversation
ntamas
approved these changes
Jun 2, 2021
Member
Agreed! The same applies to the default graph drawer as well, and maybe there's the possibility of re-using some code between the two, so I'll look into this at some point in the future. |
Member
|
Also, thanks a lot for the quick PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to address #409
The user's requested code now works on my machine in both cases, and the logic of the code is slightly improved and better documented in the code.
At some point we should consider adding some infrastructure to
MatplotlibGraphDrawerto avoid having a lot of logic in a single giant function.