Loading graph from one or two dataframes#309
Merged
ntamas merged 8 commits intoigraph:masterfrom Jul 27, 2020
Merged
Conversation
ntamas
requested changes
Jul 14, 2020
ntamas
reviewed
Jul 16, 2020
Member
ntamas
left a comment
There was a problem hiding this comment.
Looks good in general -- let's address the two comments that I have added and then it is probably good to go.
Member
Author
|
I think this can be merged now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #29, a function to read graphs from one/two dataframes, just like in R.
We are not going to implement the CSV parser anyway, so if this is fine (might need some tests?) then we can add the CSV solutions from @ntamas to the docs (I'll do that) and then close that issue.