setup.py: Support MinGW Windows build#297
Merged
ntamas merged 1 commit intoigraph:masterfrom Jul 14, 2020
Merged
Conversation
Member
|
Thanks! I'll check this PR soon; it seems like there's something wrong with Appveyor right now so the build fails there, but it's probably unrelated to the PR. I'll try to fix Appveyor first and then merge this if the build passes there. |
Member
|
Can you please merge this commit into your PR to fix the Appveyor CI build? |
014b54c to
e31d1c1
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
ntamas
approved these changes
Jul 14, 2020
Member
|
Thanks a lot and sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the setup.py tries to compile the Python extension using Visual Studio / MSVC.
However some workflows may use the MinGW version of Python instead (eg. when using GTK+ with Python). Building it is pretty simple, it can just be installed like on Linux and the Msys requirements are the same as for the build of the C core.
This pull request changes the check for build on Windows to only use MSVC when running the "native"/official CPython interpreter.