chore(devcontainer): update path to requirements file #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit: add hadolint-coatl repo
Contributor
Reviewer's GuideAdjusted development container setup by updating requirement file path and cleaning temporary files in the Dockerfile, and enhanced pre-commit checks by adding a hadolint hook. Flow diagram for pre-commit hadolint hook additionflowchart TD
A[pre-commit run] --> B{Check hooks}
B -->|hadolint| C[Run hadolint on Dockerfiles]
C --> D[Report linting results]
B -->|other hooks| E[Run other pre-commit hooks]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @cesarcoatl - I've reviewed your changes - here's some feedback:
- Consider splitting the path change in the Dockerfile and the addition of the hadolint hook into two separate commits or PRs to keep each change focused.
- Instead of
rm -rf /tmp/*, scope the cleanup to just the requirements file (/tmp/requirements.txt) to avoid accidentally removing other temp data. - Make sure any other scripts or CI configurations referencing
requirements.txtare updated to use the newpkg/requirements.txtpath.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider splitting the path change in the Dockerfile and the addition of the hadolint hook into two separate commits or PRs to keep each change focused.
- Instead of `rm -rf /tmp/*`, scope the cleanup to just the requirements file (`/tmp/requirements.txt`) to avoid accidentally removing other temp data.
- Make sure any other scripts or CI configurations referencing `requirements.txt` are updated to use the new `pkg/requirements.txt` path.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit: add hadolint-coatl repo
Summary by Sourcery
Update devcontainer Dockerfile to use the requirements file in pkg and clean up temporary files, and add hadolint to the pre-commit configuration
Build:
CI: