Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes AutoCLI placeholder markers from the Ignite scaffolding templates and switches AutoCLI option insertion from placeholder-based string replacement to AST-based appending, so new queries/messages/types can update autocli.go without relying on template sentinel comments.
Changes:
- Removed AutoCLI placeholder constants and template placeholder comment lines.
- Updated typed/list/map/singleton, query, and message generators to append AutoCLI options via new
typed.AppendAutoCLI{Query,Tx}Options. - Removed the placeholder tracer plumbing from the scaffolder runner and deleted the
ignite/pkg/placeholderpackage; added changelog entry.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ignite/templates/typed/singleton/singleton.go | Switch AutoCLI query/tx option insertion from placeholder replacement to AST append helpers. |
| ignite/templates/typed/map/map.go | Switch AutoCLI query/tx option insertion to AST append helpers (note: one CLI usage inconsistency flagged in comments). |
| ignite/templates/typed/list/list.go | Switch AutoCLI query/tx option insertion to AST append helpers. |
| ignite/templates/typed/autocli.go | New AST-based helper to append AutoCLI options and skip duplicates by RpcMethod. |
| ignite/templates/typed/autocli_test.go | Tests for duplicate-skipping behavior in the new AST append helpers. |
| ignite/templates/typed/placeholders.go | Removes typed AutoCLI placeholder constants. |
| ignite/templates/query/query.go | Switch query AutoCLI insertion to typed.AppendAutoCLIQueryOptions. |
| ignite/templates/query/placeholders.go | Removes query AutoCLI placeholder constant. |
| ignite/templates/module/create/files/base/x/{{moduleName}}/module/autocli.go.plush | Removes placeholder comment lines from the generated module template. |
| ignite/templates/message/message.go | Switch message AutoCLI insertion to typed.AppendAutoCLITxOptions. |
| ignite/services/scaffolder/type.go | Updates type scaffolding to call generators without placeholder tracer/replacer. |
| ignite/services/scaffolder/query.go | Updates query scaffolding to call generator without placeholder tracer/replacer. |
| ignite/services/scaffolder/message.go | Updates message scaffolding to call generator without placeholder tracer/replacer. |
| ignite/services/scaffolder/scaffolder.go | Removes Tracer() accessor (placeholder tracer no longer used). |
| ignite/pkg/xgenny/runner.go | Removes placeholder tracer tracking and final tracer error return. |
| ignite/pkg/placeholder/* | Deletes placeholder tracer implementation and tests. |
| changelog.md | Adds entry for removing autocli placeholders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aa2bf08 to
a07ebe7
Compare
julienrbrt
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2841