Skip to content

fix: make chatlog readable in dark mode #9995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjsparks merged 1 commit into from
Nov 25, 2025
Merged

fix: make chatlog readable in dark mode #9995

rjsparks merged 1 commit into from
Nov 25, 2025
+14 −0

Conversation

@nouralmaa
Copy link
Contributor

@nouralmaa nouralmaa commented Nov 24, 2025

Fixes #8739

@codecov
Copy link

codecov bot commented Nov 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (92f23c0) to head (73b4d82).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9995      +/-   ##
==========================================
- Coverage   88.54%   88.54%   -0.01%     
==========================================
  Files         317      317              
  Lines       42343    42385      +42     
==========================================
+ Hits        37494    37531      +37     
- Misses       4849     4854       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks
Copy link
Member

rjsparks commented Nov 25, 2025

This results in
image
which is a vast improvement, but I wonder if we should be toning down the brightness (a future task - not asking for a change to this PR).

@rjsparks rjsparks merged commit c79b35d into ietf-tools:main Nov 25, 2025
10 checks passed
@nouralmaa nouralmaa deleted the fix-chatlog-darkmode branch November 25, 2025 20:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jennifer-richards jennifer-richards jennifer-richards approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nouralmaa @rjsparks @jennifer-richards