Save YOffset between files, keep a global YOffset position _per file_ for the preview panel.#451
Closed
abourget wants to merge 2 commits intoidursun:mainfrom
Closed
Save YOffset between files, keep a global YOffset position _per file_ for the preview panel.#451abourget wants to merge 2 commits intoidursun:mainfrom
abourget wants to merge 2 commits intoidursun:mainfrom
Conversation
Revert configurable option for search highlight. Using lipgloss.Render emitted a styles reset, so we lost the styling that was there before, like background and color. Most diff tools don't tweak boldness, so we should be better off here. Hmm, underline would be better?
… for the preview panel.
7e6b248 to
f887934
Compare
Owner
|
closing due to conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, the YOffset of the preview pane would jump, because it would keep the memory of the previous offset, whatever the file was there previously.
Now if you're inspecting a patch at a given offset, it'll keep it.
A prior implementation used the change_id in the key, to keep persistence across commits, might be a good idea to bring back.
Using a global, it allows to keep the memory even if you go back and forth other revisions. Would leak minimal memory here, perhaps could implement some sort of TTL with that memory.
Whoops, this brings another PR I had done. Please review only the last commit here!