This is subject to it making sense to maintainers and it being something of value for jjui users. Please vote 👍 / 👎 .
from #240 comment about making the output of commands sticky, and later about instead of making non-errored output sticky, have a way to see output of already closed flash messages.
What are you planning to implement?
Show a window with the list (latest first) commands run with their respective output.
Proposed Approach
- How will this feature work? For example, describe how the user would interact with jjui using this new feature.
A new shortcut will open our center stacked view with a list of previously closed flash messages.
Each "row" has a success or error emoji, followed by exit status (int), the timestamp and command that was run colored either green or red according to error status. Followed by the lines of the command output.
You can move as usual up or down using j/k up/down and close using esc. No other key is handled during this view.
shortcut proposal: F (flash history). (current lowercase f is ace jump)
- How will this integrate with or impact existing features?
We will be able to show the output of all commands run by jjui on behalf of the user, except for those of sh exec or jj exec since these are given complete IO control and jjui does not intercepts their output in any way.
Implementation Details
Output of commands is not stored in disk, and is lost when jjui terminates.
Testing Strategy
How do you plan to test this implementation?
Alternatives Considered
What other implementation approaches have you considered? Why did you choose this particular approach?
An alternative is not to have another window for flash messages but be able to see the output at oplog (not sure about this)
Breaking Changes
N/A
Questions for Discussion
Do you would like for jjui to have this feature?
This is subject to it making sense to maintainers and it being something of value for jjui users. Please vote 👍 / 👎 .
from #240 comment about making the output of commands sticky, and later about instead of making non-errored output sticky, have a way to see output of already closed flash messages.
What are you planning to implement?
Show a window with the list (latest first) commands run with their respective output.
Proposed Approach
A new shortcut will open our center stacked view with a list of previously closed flash messages.
Each "row" has a success or error emoji, followed by exit status (int), the timestamp and command that was run colored either green or red according to error status. Followed by the lines of the command output.
You can move as usual up or down using j/k up/down and close using esc. No other key is handled during this view.
shortcut proposal:
F(flash history). (current lowercasefis ace jump)We will be able to show the output of all commands run by jjui on behalf of the user, except for those of
sh execorjj execsince these are given complete IO control and jjui does not intercepts their output in any way.Implementation Details
Output of commands is not stored in disk, and is lost when jjui terminates.
Testing Strategy
How do you plan to test this implementation?
Alternatives Considered
What other implementation approaches have you considered? Why did you choose this particular approach?
An alternative is not to have another window for flash messages but be able to see the output at
oplog(not sure about this)Breaking Changes
N/A
Questions for Discussion
Do you would like for jjui to have this feature?