Make bitmaskWithRejectionM inclusive in the upper bound#62
Merged
lehins merged 1 commit intoinstances-and-warningsfrom Mar 30, 2020
Merged
Make bitmaskWithRejectionM inclusive in the upper bound#62lehins merged 1 commit intoinstances-and-warningsfrom
lehins merged 1 commit intoinstances-and-warningsfrom
Conversation
lehins
reviewed
Mar 30, 2020
tests/Spec.hs
Outdated
| , integralSpec @CIntMax | ||
| , integralSpec @CUIntMax | ||
| , integralSpec @Integer | ||
| , rangeSpec @Word8 |
Collaborator
There was a problem hiding this comment.
There is no need for all of these rangeSpec calls here, integralSpec invokes rangeSpec
I structured it in such a way that you only need specify a type only once and all of the applicable specs should go in there, precisely to avoid this sort of redundancy
Collaborator
Author
There was a problem hiding this comment.
My bad! I've removed the rangeSpec calls for Char and Bool now since they are already covered by integralSpec: feac91f#diff-47e9594b3c7ba1c5f6e32c4a96aead95R43-R44
a6fd6b0 to
de4ba61
Compare
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as the
UniformRangedocumentation says.Builds on top of #58. I suggest we just merge this PR into
instances-and-warningsto make this part of #58.