Skip to content

[POC] Create a corpus of various ics files for more robust tests#236

Closed
C4ptainCrunch wants to merge 4 commits intomainfrom
corpus
Closed

[POC] Create a corpus of various ics files for more robust tests#236
C4ptainCrunch wants to merge 4 commits intomainfrom
corpus

Conversation

@C4ptainCrunch
Copy link
Copy Markdown
Member

@C4ptainCrunch C4ptainCrunch commented Feb 29, 2020

Uncovered bugs

Other

I might remove the incriminating file if we don't want to support that case

  • We fail if PRODID is not present. Maybe we should just print a warning.
  • We are case sensitive and fail when the open line has not the same case as the close (ical4j/korganizer-lowercase.ics): BEGIN:Vcalendar vs END:vCalendaR
  • We fail on subsecond precision date-time (eg 19970701T190000Z). RFC says second = 2DIGIT

Unknowns

  • We fail on ical4j/1106817412.ics due to utf-8 wizardry ?
  • We fail on tabs inside a content line (ical4j/mansour.ics) does the RFC accept it ?

@N-Coder
Copy link
Copy Markdown
Member

N-Coder commented Mar 1, 2020

Could you rebase this onto v0.7? That should fix the two "unknowns" as #227 allows any UTF-8 characters and also includes a fix for tabs.

@C4ptainCrunch
Copy link
Copy Markdown
Member Author

C4ptainCrunch commented Mar 1, 2020

Indeed, the tabs issue is fixed 🎉
For the utf-8, it even seems that it's the file reading that fails because of invalid utf-8 so i guess i'll just remove the file

@N-Coder
Copy link
Copy Markdown
Member

N-Coder commented May 16, 2020

I have some code to pull all the mozilla thunderbird holiday calendars to generate a sufficiently big input file for #244, but these should also make a good addition here. I'll take care of that once the other stuff is through.

@N-Coder N-Coder mentioned this pull request May 16, 2020
Open
21 tasks
Base automatically changed from master to main January 17, 2021 11:46
@N-Coder N-Coder mentioned this pull request Aug 5, 2021
Closed
@N-Coder
Copy link
Copy Markdown
Member

N-Coder commented Nov 8, 2021

Here are some further potential sources for ICS data:
https://github.com/public-apis/public-apis#calendar

@C4ptainCrunch
Copy link
Copy Markdown
Member Author

C4ptainCrunch commented Jul 4, 2022

I'm doing a bit of cleanup. This PR seems stale and not ready to be merged so i'll close it but if somebody wants to work on it again, feel free to reopen !

@N-Coder
Copy link
Copy Markdown
Member

N-Coder commented Jul 10, 2022

I guess this would still be a very good thing to keep track of (and to continue working on) regarding the test suite for 0.8...
But at least its linked from the To-Do list there some it should be findable. 🤷‍♂️

@diemoschwarz diemoschwarz mentioned this pull request Oct 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@C4ptainCrunch @N-Coder