Skip to content

Restructure documentation#223

Merged
C4ptainCrunch merged 16 commits intoics-py:masterfrom
tomschr:feature/220-improve-doc
Mar 22, 2020
Merged

Restructure documentation#223
C4ptainCrunch merged 16 commits intoics-py:masterfrom
tomschr:feature/220-improve-doc

Conversation

@tomschr
Copy link
Copy Markdown
Contributor

@tomschr tomschr commented Feb 8, 2020

This PR is a first draft for issue #220. It contains the following changes:

  • Create subdirectories for the four types howtos, tutorials, explanation, and reference.
  • Separate/sort existing documentation into these sub dirs.
  • If necessary, adapt title, split files to better fit into the structure.

Marked it as "draft" for the time being as it's not finished and only the skeleton for our future documentation. It's also to make sure the structure is good enough before I move on and add more content.

Some changes may seem radical. I'm sure there are probably better ways how to structure it, but it's a start so we can discuss the pros and cons. I'm sure we can improve it together! 😃

There are still a lot of work to do:

  • I haven't found a good place for the advanced.rst file. Probably it needs to be rewritten and can be integrated into a tutorial, I'm not sure... 🤔
  • Speaking of tutorials, I haven't included one yet. If we have a clearer picture of if and how this will work, we can add them later.
  • There are a lot of files and sections which can (and should be!) extended. I assume, we don't have to do it with one pull request, so we can gradually move on, if you think this structure is useful.
  • The API contains a warning: autodoc: failed to import class 'parse.Container' from module 'ics'; the following exception was raised: No module named 'ics.parse' and Duplicate explicit target name: "github thread". I leave that to someone else to fix it. 😉
Screenshot (click me to show)

ics py-doc

@C4ptainCrunch @N-Coder So what do you think? Could that work as a start? Anything you like/dislike? Let me know! 👍

@tomschr tomschr requested a review from C4ptainCrunch February 8, 2020 14:18
@tomschr tomschr changed the title Improve ics.py documentation Restructure ics.py documentation Feb 8, 2020
@tomschr tomschr force-pushed the feature/220-improve-doc branch from 6285638 to 074fc25 Compare February 9, 2020 13:01
@C4ptainCrunch
Copy link
Copy Markdown
Member

It looks like a good start to me 👍

@tomschr
Copy link
Copy Markdown
Contributor Author

tomschr commented Feb 17, 2020

@N-Coder Niko, you've showed an interest of having a section regarding the ICS format. I've added a placeholder file (see doc/explanation/icalender-format.rst) with a comment.

I'm not very familiar with ICS, but I would be willing to review and comment it if you would like to provide some text. Wanna try? 😉

@tomschr tomschr marked this pull request as ready for review February 17, 2020 21:56
@tomschr
Copy link
Copy Markdown
Contributor Author

tomschr commented Feb 17, 2020

I've moved one file into another category (contributing.rst), but most of it is ready to review. The rest is the same (structure-wise). Nikita seemed to like it. 😉

Of course it is not really finished. As I'm not sure what else I can provide, I think it's time to decide if we want to publish it as the current state and improve it step-by-step, or we want to do some more modifications in this PR. If you like, I can squash the commits into one if you prefer it that way.

@C4ptainCrunch what do you like?

@C4ptainCrunch
Copy link
Copy Markdown
Member

I mirrored your branch on this repo (the branch is named pr/223) so that ReadTheDocs can grab it. This means you can now preview your changes over there : https://icspy.readthedocs.io/en/pr-223/

Also, as we just released ics.py 0.7, i merged master into (the mirror of) your branch. You might want to pull that into yours :)

@C4ptainCrunch
Copy link
Copy Markdown
Member

It also seems like the reorg broke some links and footnotes.
Here are the errors i get while building on my machine:

WARNING: autodoc: failed to import class 'parse.Container' from module 'ics'; the following exception was raised:
No module named 'ics.parse'
WARNING: autodoc: failed to import class 'parse.ContentLine' from module 'ics'; the following exception was raised:
No module named 'ics.parse'
ics.py/doc/explanation/howto.rst:2: WARNING: Duplicate explicit target name: "github thread".
ics.py/doc/explanation/limitations.rst:45: WARNING: Too many autonumbered footnote references: only 0 corresponding footnotes available.
ics.py/doc/explanation/limitations.rst:45: WARNING: Unknown target name: "malformed".
ics.py/doc/explanation/limitations.rst:51: WARNING: Unknown target name: "errors".

@C4ptainCrunch
Copy link
Copy Markdown
Member

Small other comment : things like Create a ICS File with Thunderbird seem weird to have in the side menu (maybe also because the title is long). We should find a way to make it prettier :)

image

@tomschr
Copy link
Copy Markdown
Contributor Author

tomschr commented Feb 29, 2020

@C4ptainCrunch

It also seems like the reorg broke some links and footnotes.
Here are the errors i get while building on my machine:

Thanks for the hint, but I get the same warnings in master too. 😉 That's why I assume, It's not caused by my reorganization of the doc.

Small other comment : things like Create a ICS File with Thunderbird seem weird to have in the side menu (maybe also because the title is long). We should find a way to make it prettier :)

I can abbreviate it and remove the "with Thunderbird" part. That's easy to fix.

However, just as a more general note, it will loose clarity and you can get into the same issue again when having a longer title. IMHO, this is not a documentation issue, but a layout issue. 😉

tomschr and others added 16 commits March 21, 2020 19:15
* Remove/rename files:
  - examples.rst: Use content in quickstart.rst
  - misc.rst -> explanation/misc.rst

* Move files:
  - api.rst -> reference/api.rst
  - introduction.rst -> explanation/icalender-format.rst
  - about.rst -> explanation/about.rst

* Add new files:
  - reference/changelog.rst
  - howtos/installation.rst, howtos/quickstart.rst
  - explanation/contributing.rst
There are limitations and howto. Better we separate these;
additionally, the titles get more attention
* Rephrase first paragraph a bit
* Separate/sort existing documentation into the four
  types: howtos, tutorials, explanation, and reference
* Create new files as necessary
* Rename some files to make it visible about the content
* Explain how to check version of Python & pip
* Focus on pip
* Show how to install ics.py with and without a
  virtual environment
* Correct title
  * Use ^ instead of < to avoid lines looking like conflict markers
  * Amend main title with "... to ics.py"
* Use verbs and active voice in some list entries to engage our
  developers
@tomschr tomschr force-pushed the feature/220-improve-doc branch from ccaf32f to 92eb26c Compare March 21, 2020 18:19
@C4ptainCrunch
Copy link
Copy Markdown
Member

Ok, let's go ! I'm merging this too if it's ok to you then we can iterate again with smaller PR on master :)

@tomschr
Copy link
Copy Markdown
Contributor Author

tomschr commented Mar 21, 2020

@C4ptainCrunch Yes, please do. I agree, we can improve it in other PRs step-by-step. Thanks! 👍

Oh, one question: should I squash all commits?

@C4ptainCrunch C4ptainCrunch changed the title Restructure ics.py documentation Restructure documentation Mar 22, 2020
@C4ptainCrunch C4ptainCrunch merged commit f6cb122 into ics-py:master Mar 22, 2020
@tomschr tomschr deleted the feature/220-improve-doc branch March 22, 2020 09:49
@N-Coder N-Coder mentioned this pull request May 16, 2020
21 tasks
@N-Coder N-Coder added this to the Version 0.8 milestone May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants