Support configurable LineHeight in text widgets#1828
Merged
hecrj merged 1 commit intoadvanced-textfrom May 5, 2023
Merged
Conversation
clarkmoody
approved these changes
May 4, 2023
Contributor
clarkmoody
left a comment
There was a problem hiding this comment.
Great change. No red flags from a quick inspection.
Comment on lines
+63
to
+71
| /// The height of a line of text in a paragraph. | ||
| #[derive(Debug, Clone, Copy, PartialEq)] | ||
| pub enum LineHeight { | ||
| /// A factor of the size of the text. | ||
| Relative(f32), | ||
|
|
||
| /// An absolute height in logical pixels. | ||
| Absolute(Pixels), | ||
| } |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new configurable
line_heightattribute to text widgets, replacing the previous hardcoded value (1.2).Line height can be set using the new
LineHeightenum, which hasRelative(f32)andAbsolute(Pixels)variants.