Merged
Conversation
Contributor
|
As some one who knows nothing about fonts, I feel like this could result in some problems:
I wonder if there is any room for warnings in debug mode to detect text that requires advanced shaping. |
Member
Author
|
We will get there eventually. Developers need to know what they are doing for now. |
Merged
Contributor
|
Would making the default Also, wouldn't it be better if the enum was marked as |
|
Simply make advanced shaping default, and this is how a lot of GUI frameworks work. i18n will heavily depend on fallback and shaping. |
Member
Author
|
Eventually, maybe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Shapingenum in thetextmodule that allows users to control the shaping strategy used to lay out text.The
Basicstrategy is considerably more efficient (specially in debug builds!) and works well for simple scripts (the use cases the library currently satisfies).Because of this,
Basicis the default strategy used in text-based widgets (except theTextInput). In other words,Advancedshaping must be explicitly enabled when necessary.