fix(translation): preserve OpenAI function tool strict#441
Merged
icebear0828 merged 1 commit intoicebear0828:devfrom May 7, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
f66a619 to
e0f625a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stricton OpenAI-compatible function tool definitions.functionstostrict: falsewhen the client does not specify it.strict: truepreservation.Why
OpenAI Responses-style tool handling can normalize omitted
strictinto strict schema behavior. That can make previously optional tool schema properties mandatory, which breaks MCP-style tools that intentionally use optional fields or mutually exclusive request modes.This keeps strict mode available for clients that explicitly request it, while preserving non-strict compatibility for OpenAI chat/function tools by default.
Test plan
npm test -- tests/unit/translation/tool-format.test.ts