feat: external support RegExp and not external sub path of package#673
Merged
feat: external support RegExp and not external sub path of package#673
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the external dependencies handling to support RegExp and array configurations, and revises the related documentation and types accordingly.
- Updated documentation in config.md to reflect the new externals types and defaults.
- Extended externals type and handling in types.ts and getRollupOptions.ts to support arrays including RegExp.
- Expanded the list of built-in modules in builtinModules.ts and made minor naming updates in workflows and changesets.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/docs/reference/config.md | Updated documentation to describe new externals support. |
| packages/pkg/src/types.ts | Modified externals type to include arrays with RegExp and objects. |
| packages/pkg/src/helpers/getRollupOptions.ts | Updated logic to process externals array including RegExp support. |
| packages/pkg/src/helpers/builtinModules.ts | Added additional Node built-in modules with node: prefix. |
| .github/workflows/release-next.yml | Renamed the release workflow for clarity. |
| .changeset/dry-pots-buy.md | Updated changeset with the new external support feature. |
Comments suppressed due to low confidence (1)
packages/pkg/src/helpers/builtinModules.ts:72
- The module 'node:sea' does not appear to be a standard Node built-in. Verify if this entry is a typo or if it is intentionally included.
'node:sea',
More templates
@ice/create-pkg
ice-npm-utils
@ice/pkg-plugin-docusaurus
@ice/pkg-plugin-jsx-plus
@ice/pkg
@ice/pkg-plugin-rax-component
@ice/remark-react-docgen-docusaurus
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.