feat(chdb): implement chdb - the embedded clickhouse - backend#8497
Closed
kszucs wants to merge 11 commits into
Closed
feat(chdb): implement chdb - the embedded clickhouse - backend#8497kszucs wants to merge 11 commits into
kszucs wants to merge 11 commits into
Conversation
cpcloud
requested changes
Feb 29, 2024
|
|
||
| """ | ||
| with contextlib.suppress(AttributeError): | ||
| query = query.sql(dialect="clickhouse", pretty=True) |
Member
There was a problem hiding this comment.
Suggested change
| query = query.sql(dialect="clickhouse", pretty=True) | |
| query = query.sql(dialect=self.dialect, pretty=True) |
Comment on lines
+97
to
+98
| names = table.column("name").to_pylist() | ||
| types = table.column("type").to_pylist() |
Member
There was a problem hiding this comment.
Suggested change
| names = table.column("name").to_pylist() | |
| types = table.column("type").to_pylist() | |
| names = table["name"].to_pylist() | |
| types = table["type"].to_pylist() |
| if external_tables: | ||
| raise NotImplementedError("External tables are not yet supported") | ||
|
|
||
| df = self.con.query(sql, "arrowtable").to_pandas() |
Member
There was a problem hiding this comment.
Suggested change
| df = self.con.query(sql, "arrowtable").to_pandas() | |
| df = self.con.query(sql, fmt="arrowtable").to_pandas() |
| if external_tables: | ||
| raise NotImplementedError("External tables are not yet supported") | ||
|
|
||
| table = self.con.query(sql, "arrowtable") |
Member
There was a problem hiding this comment.
Suggested change
| table = self.con.query(sql, "arrowtable") | |
| table = self.con.query(sql, fmt="arrowtable") |
Comment on lines
+34
to
+35
| # [(value,)] = self.connection.con.query("SELECT true").result_set | ||
| # return isinstance(value, bool) |
Member
There was a problem hiding this comment.
Suggested change
| # [(value,)] = self.connection.con.query("SELECT true").result_set | |
| # return isinstance(value, bool) |
We definitely will not be supporting versions of chdb that don't support native booleans.
| def ddl_script(self) -> Iterable[str]: | ||
| parquet_dir = self.data_dir / "parquet" | ||
| for sql in super().ddl_script: | ||
| yield sql.format(parquet_dir=parquet_dir) |
Member
There was a problem hiding this comment.
I'd rather not introduce templating if we can avoid it. How about hard coding the path to ci/ibis-testing-data/... like we do with everything else?
| """ | ||
| con = self.connection.con | ||
|
|
||
| con.query(f"CREATE DATABASE {database} ENGINE = Atomic") |
Member
There was a problem hiding this comment.
Does this work with our process-based parallel testing setup (i.e., pytest-xdist)?
| default_backend: Optional[Any] = None | ||
| context_adjustment: ContextAdjustment = ContextAdjustment() | ||
| sql: SQL = SQL() | ||
| chdb: Optional[Config] = None |
Member
Author
|
I won't have time to keep working on this in the near future, so closing it. |
Contributor
Member
|
Going to reclose this for now. Can always reopen if we want to continue the work, but no need to keep it open if we're not hacking on it proactively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A big chunk of the backends testing suite is already passing, but there is still work to do:
Test suite is currently at
247 failed, 1067 passed, 28 skipped, 29854 deselected, 131 xfailed, 6 errors