chore(dev): replace current flake8-based and other linting tools with ruff#5057
Merged
kszucs merged 1 commit intoibis-project:masterfrom Dec 21, 2022
Merged
chore(dev): replace current flake8-based and other linting tools with ruff#5057kszucs merged 1 commit intoibis-project:masterfrom
ruff#5057kszucs merged 1 commit intoibis-project:masterfrom
Conversation
Contributor
8e657e4 to
14128df
Compare
Codecov Report
@@ Coverage Diff @@
## master #5057 +/- ##
==========================================
- Coverage 95.06% 91.29% -3.77%
==========================================
Files 394 388 -6
Lines 44018 43416 -602
Branches 4319 4293 -26
==========================================
- Hits 41846 39638 -2208
- Misses 1668 3290 +1622
+ Partials 504 488 -16
|
kszucs
reviewed
Dec 21, 2022
kszucs
reviewed
Dec 21, 2022
Member
|
@cpcloud can you add a more descriptive name to the PR? :) |
ruff
Member
Author
Done! |
kszucs
approved these changes
Dec 21, 2022
Member
kszucs
left a comment
There was a problem hiding this comment.
After including the breaking change note it looks good to me!
Member
Author
|
I'll squash into a single commit. |
Replace flake8 and friends with `ruff`. BREAKING CHANGE: Expression types have been removed from `ibis.expr.api`. Use `import ibis.expr.types as ir` to access these types.
Member
|
I have
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces all of our flake8 checks and tools with
ruff, which is Python linter implemented in Rust designed to be fast, lightweight and combine the most commonly used flake8 plugins into a single tool. While I do not care too much about the performance for ibis developement (though I do for my LSP configuration!) I do care about tool consolidation, which is the main purpose of this PR.