HDZERO VTX OSD Support#7668
Conversation
|
Awesome! |
|
So far, you have not run python script to generate Settings.md |
|
I have run the script and updated the PR, but the test is still failing. I ran the same test on my local branch and it passes ok. |
|
I just had a look a settings.md and it needs to be updated. If you look for a boolean value, it should have off and on in the min and max table columns respectively. You may need to fetch upstream on your branch to get the latest documents generating script. |
|
Hi. I did update using the script specified. When I run the commands in the failure notification, it passes ok. I’m not sure what to do now.
…Sent from my phone
On 24 Dec 2021, at 17:27, Darren Lines ***@***.***> wrote:
I just had a look a settings.md and it needs to be updated. If you look for a boolean value, it should have off and on in the min and max table columns respectively.
You may need to fetch upstream on your branch to get the latest documents generating script.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.
|
|
There is definitely a problem with the settings.md file. In this screenshot, the settings.md on the left is the one submitted with this PR. The one on the right is the master. Check out the How does the file look on your computer? If you have the OFF and ON in the 66 | member["min"] = "OFF" I just checked your branch, and the creation script is not up to date. So the fetch upstream on your branch should get everything sorted. |
|
Argh. Yes, master has moved on. I’ll update my branch tomorrow.
Cheers.
…Sent from my phone
On 24 Dec 2021, at 18:17, Darren Lines ***@***.***> wrote:
There is definitely a problem with the settings.md file. In this screenshot, the settings.md on the left is the one submitted with this PR. The one on the right is the master. Check out the beeper_pwm_mode section. You can see on the master that the MIN and MAX in the table have OFF and ON. The version in this PR does not.
How does the file look on your computer? If you have the OFF and ON in the beeper_pwm_mode table, it's correct and just hasn't been pushed to the change branch. if the OFF and ON for MIN and MAX are missing, you have the wrong document creation script. If you perform a fetch upstream on your branch, it should get the correct creation script. It is src/utils/update_cli_docs.py and should have the lines:
66 | member["min"] = "OFF"
67 | member["max"] = "ON"
I just checked your branch, and the creation script is not up to date. So the fetch upstream on your branch should get everything sorted.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.
|
|
Please do not merge yet as I am working on an optimisation to reduce the amount of data being sent over the serial port. |
|
Ok, all done. Please consider for merging . |
|
Thanks @geoffsim I'll quickly check analog functions and DJI for regression and then we will go futher |
|
Apologies for the late change. A flight test today showed an issue with the AHI when aircraft nears a 90 degree bank. The AHI code needs work at some stage to reduce the number of changes reported each time it is called. Currently it (AHI code) blanks out the AHI and then redraws it. This can create a lot of changes that have to be sent to the OSD, especially around the 90 degree bank when the AHI is spanning multiple lines. I'm sure the code could be optimised. |
|
@geoffsim This PR completely breaks the Analog OSD functionality. After flashing with default, no elements are visible and I found no way to make them visible. This has to be fixed before merging. |
DzikuVx
left a comment
There was a problem hiding this comment.
This PR breaks Analog OSD function, no OSD elements are visible
|
I’ll set up an analog system and test tomorrow.
…Sent from my phone
On 13 Jan 2022, at 12:26, Paweł Spychalski ***@***.***> wrote:
@DzikuVx requested changes on this pull request.
This PR breaks Analog OSD function, no OSD elements are visible
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.
|
|
Thanks @geoffsim |
|
Fixed, tested, and added to the PR. Regards, |
|
Does it work with all HD-receivers? |
|
All HDZero VTX and VRX models, yes. |
|
I have some more changes to come in the next few days. Please do not review until then. |
|
Ok. But I'd like to have the final code until end of this week as well.
Maybe beginning of the next as I'd like to release RC for 4.1 in the last
week of January
wt., 18 sty 2022, 09:02 użytkownik Geoff Sim ***@***.***>
napisał:
… I have some more changes to come in the next few days. Please do not
review until then.
—
Reply to this email directly, view it on GitHub
<#7668 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHMBG2MLT7GUBNNLSA4JCTUWUNAVANCNFSM5KLVEWWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Increase the TX buffer size of the selected serial port to accommodate. Add debug code (#defined out)
|
Changes complete. Please review. |
|
Nice! I'll test and review when I will find a moment |
|
I promise to not make any more changes! That last one was important to facilitate the "OSD OFF" mode. Known issue (HDZero VTX specific): |
|
And it's merged. I will run some more tests and build PR1 for 4.1 quite soon |

Update OSD coordinate system to allow up to 64x64 (HD) from original of 32x32 (SD).
Update DJI OSD code to map back to SD coordinate system.
Update DJI fixed element co-ordinates to be more central on screen.
Add HD ZERO OSD support for 50x18 OSD canvas.
(See also PR for supporting configurator changes)