Skip to content

Extend the init method with a generic parameter for backend options#1878

Merged
adrai merged 1 commit into
i18next:masterfrom
2Pacalypse-:master
Dec 10, 2022
Merged

Extend the init method with a generic parameter for backend options#1878
adrai merged 1 commit into
i18next:masterfrom
2Pacalypse-:master

Conversation

@2Pacalypse-

Copy link
Copy Markdown
Contributor

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 91.436% when pulling 602f971 on 2Pacalypse-:master into 913190d on i18next:master.

@2Pacalypse-

Copy link
Copy Markdown
Contributor Author

@adrai

adrai commented Dec 10, 2022

Copy link
Copy Markdown
Member

lgtm...
Which version increment do you suggest for i18next and for the backends?
major, minor, patch?

@2Pacalypse-

Copy link
Copy Markdown
Contributor Author

Probably minor.

@adrai adrai merged commit cb2db46 into i18next:master Dec 10, 2022
@adrai

adrai commented Dec 10, 2022

Copy link
Copy Markdown
Member

thank you very much for your contribution...
all version has been released...
I will now proceed to check other backends...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants