Check for #cloud-config comment in first line#178
Merged
StefanScherer merged 2 commits intomasterfrom Jun 1, 2020
Merged
Conversation
StefanScherer
commented
Jun 1, 2020
116c941 to
f0aeb1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS we already validate the user-data yaml file, but this does not include a check for the
#cloud-configcomment in the first line.According to https://cloudinit.readthedocs.io/en/latest/topics/faq.html#how-can-i-debug-my-user-data it is one of the two top most problems. In my experience it IS the top most problem and to be honest I do not understand why this cannot be fixed in cloud-init 😅
Helps #177 to find problems before users run into boot problems.