#109: wifi params to user-data#165
Conversation
added * naive implementation of SSID/PSK settings to user-data * basic tests to try to cover this
|
Thank you for the contribution and the tests! |
|
We should be able to add something like That way it leaves comments alone. |
* should negate for commented lines Tests * user-data test files - wifi commented and uncommented * new tests fo mixing params for user-data & wifi creds * new refute test - commented ssid/psk lines should be unchanged
* fixes to pass tests Now ignores wifi params for user-data if the wifi section is commented. That means basic implementation works if also using a user-data file where the wifi section is present and not commented.
|
I've just pushed some changes to prevent the sed_i for commented lines. Probably not enough to close issue #109, but would cover my use-case
As you said @StefanScherer, an alternative marking of the wifi comment block might be an option to make a full implementation simpler, or just copy in the entire wifi section if no uncommented section is found... |
StefanScherer
left a comment
There was a problem hiding this comment.
Let's merge this, it is at least an improvement to have this parameters work again.
Thanks for the test cases!
LGTM
added