Java language level syntactic sugaring #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypfvieh
requested changes
Jan 30, 2024
Owner
hypfvieh
left a comment
There was a problem hiding this comment.
Please review the 2 marked files. Rest looks good
|
|
||
| if (_variant.getType() instanceof DBusStructType && _variant.getValue() instanceof Object[]) { | ||
| Class<?>[] argTypes = Arrays.stream((Object[]) _variant.getValue()).map(Object::getClass).toArray(size -> new Class<?>[size]); | ||
| Class<?>[] argTypes = Arrays.stream((Object[]) _variant.getValue()).map(Object::getClass).toArray((IntFunction<Class<?>[]>) Class[]::new); |
Owner
There was a problem hiding this comment.
This can be simplified to Class<?>[] argTypes = Arrays.stream((Object[]) _variant.getValue()).map(Object::getClass).toArray(Class<?>[]::new);
Non-functional change - make use of new Java language features available up to Java 17 LTS - Use String.repeat() - Replace statements with enhanced switch - Use pattern variable - Convert to enhanced for-loop - Prefer StringBuilder over StringBuffer - Remove unnecessary boxing/unboxing - Use Objects.equals() rather than equals() expression - Replace explicit types by diamond operator - Use lambdas for anonymous types - Use Comparator combinator - Introduce method references for lambdas - Change statement to expression lambdas - Check for null using method call
954b11a to
f5937d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-functional change - make use of new Java language features available up to Java 17 LTS