Skip to content

Add Tests of BrotliDecoderChannel#147

Merged
hyperxpro merged 1 commit into
hyperxpro:mainfrom
joakime:tests/one_byte_at_a_time_decode
Jul 17, 2024
Merged

Add Tests of BrotliDecoderChannel#147
hyperxpro merged 1 commit into
hyperxpro:mainfrom
joakime:tests/one_byte_at_a_time_decode

Conversation

@joakime

@joakime joakime commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

Motivation:

Noticed there were no tests for BrotliDecoderChannel, so here are a few for you to add.

Modification:

Created test cases for BrotliDecoderChannel.

Result:

See test cases

@hyperxpro

Copy link
Copy Markdown
Owner

Let me know if you want me to cut a release.

@joakime

joakime commented Jul 17, 2024

Copy link
Copy Markdown
Contributor Author

Let me know if you want me to cut a release.

Still working on the basics of integration on my side.
If you want to cut a release in the next month or two for your own reasons, don't let me stop you.

There's no rush for a release of brotli4j from me (yet).

@hyperxpro

Copy link
Copy Markdown
Owner

I don't have any release timeline but I'd help in every possible way to help in your integration in Jetty. :)

Btw, is the PR up?

@hyperxpro hyperxpro merged commit 2eddacf into hyperxpro:main Jul 17, 2024
@hyperxpro

Copy link
Copy Markdown
Owner

Thanks a lot!

@joakime joakime deleted the tests/one_byte_at_a_time_decode branch July 17, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants