Make EncoderJNI and EncoderJNI.Wrapper public#124
Merged
Conversation
Contributor
Author
|
cc @hyperxpro |
Owner
|
You might wanna make methods public too. |
Contributor
Author
|
@hyperxpro Thanks, updated the PR and description. |
hyperxpro
approved these changes
Dec 28, 2023
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
This PR is aimed to mark EncoderJNI and EncoderJNI.Wrapper as public class since DecoderJNI and DecoderJNI.Wrapper are already public class. Meanwhile it also mark methods from EncoderJNI.Wrapper as public.
Modification:
Add public modifier in EncoderJNI and EncoderJNI.Wrapper.
Add public modifier in methods of EncoderJNI.Wrapper.
Result:
Fixes #123