Skip to content

Feature/forward tokens and messages to firebase plugin#3

Merged
deniszpua merged 4 commits intomasterfrom
feature/forward-tokens-and-messages-to-firebase-plugin
Nov 20, 2020
Merged

Feature/forward tokens and messages to firebase plugin#3
deniszpua merged 4 commits intomasterfrom
feature/forward-tokens-and-messages-to-firebase-plugin

Conversation

@deniszpua
Copy link
Contributor

Resolves hypertrack/quickstart-flutter#8
Hey @bikcrum!
Could you, plz, confirm that the solution works for you as well?
We've used approach No 2 from your proposal but forward messages not to service but to receiver, as default plugin service implementation ignores them https://github.com/FirebaseExtended/flutterfire/blob/d5476e64e58fd06a70f5d2ec728cdad288905352/packages/firebase_messaging/firebase_messaging/android/src/main/java/io/flutter/plugins/firebase/messaging/FlutterFirebaseMessagingService.java#L22

@deniszpua deniszpua self-assigned this Nov 16, 2020
@bikcrum
Copy link

bikcrum commented Nov 18, 2020

@deniszpua There are breaking changes in firebase_messaging 8.0.0-dev1 and no stable release has been made as of now. Your solution works well with these changes however doesn't support backward compatibility. (for versions <=7.0.3) as a classpath is different. We need to test this after there is a stable release of firebase_messaging and is updated in pub.dev and only merge PR after that.

@deniszpua
Copy link
Contributor Author

@bikcrum Thanks for checking it out. I believe it would be wiser for us to switch from FirebaseMessagingService extension to broadcast receiver in HyperTrack SDK, since it seems like BroadcastReceiver is the best option to organize multiple handlers.

@deniszpua deniszpua force-pushed the feature/forward-tokens-and-messages-to-firebase-plugin branch from fb37cae to 4c5ffae Compare November 20, 2020 08:46
@deniszpua deniszpua merged commit f5e958f into master Nov 20, 2020
@deniszpua deniszpua deleted the feature/forward-tokens-and-messages-to-firebase-plugin branch November 20, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hypertrack is preventing FCM notification

2 participants