Skip to content

feat(iroha_torii): stubs for feature-gated endpoints#5385

Merged
0x009922 merged 2 commits intohyperledger-iroha:mainfrom
0x009922:torii-stubs
Apr 6, 2025
Merged

feat(iroha_torii): stubs for feature-gated endpoints#5385
0x009922 merged 2 commits intohyperledger-iroha:mainfrom
0x009922:torii-stubs

Conversation

@0x009922
Copy link
Copy Markdown
Contributor

Close #5383

  • Covered endpoints gated by telemetry, schema, and profiling features
  • Added profiling-endpoint feature to irohad

API Changes

When endpoints are feature-gated away, they no longer return 404 Not Found, but 501 Not Implemented with a descriptive message. For example, for GET /status:

HTTP/1.1 501 Not Implemented
content-type: text/plain; charset=utf-8
content-length: 115
date: Mon, 31 Mar 2025 02:03:48 GMT

This endpoint is not available on this version of "irohad", as it was compiled without the "telemetry" feature flag

@0x009922 0x009922 added the api-changes Changes in the API for client libraries label Mar 31, 2025
@0x009922 0x009922 self-assigned this Mar 31, 2025
@0x009922 0x009922 enabled auto-merge (squash) April 6, 2025 23:52
0x009922 added 2 commits April 7, 2025 08:52
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
@0x009922 0x009922 merged commit c1d8b5e into hyperledger-iroha:main Apr 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-changes Changes in the API for client libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add stubs for the absent telemetry endpoints when compiled without telemetry feature

3 participants