build: warn on unused, not deny#5377
Merged
0x009922 merged 2 commits intohyperledger-iroha:mainfrom Mar 28, 2025
Merged
Conversation
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
s8sato
approved these changes
Mar 21, 2025
aoyako
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMO, setting
unusedtodenyis a terrible default. It is an obstacle in development. It doesn't have impact on build.It is of course good to have code clean, and I think
warnis sufficient to achieve it.Feel free to reject this PR if you disagree.